From dc6dc4a44472f6546436747fc1628a9a037ce096 Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Fri, 4 Nov 2016 09:38:21 +0800 Subject: [PATCH] Support send notification to commit author by check email. Signed-off-by: Bo-Yi Wu --- main.go | 6 ++++++ plugin.go | 31 ++++++++++++++++++------------- plugin_test.go | 30 +++++++++++++++++++++--------- 3 files changed, 45 insertions(+), 22 deletions(-) diff --git a/main.go b/main.go index eb7b438..d406610 100644 --- a/main.go +++ b/main.go @@ -109,6 +109,11 @@ func main() { Usage: "git author name", EnvVar: "DRONE_COMMIT_AUTHOR", }, + cli.StringFlag{ + Name: "commit.author.email", + Usage: "git author email", + EnvVar: "DRONE_COMMIT_AUTHOR_EMAIL", + }, cli.StringFlag{ Name: "commit.message", Usage: "commit message", @@ -163,6 +168,7 @@ func run(c *cli.Context) error { Commit: c.String("commit.sha"), Branch: c.String("commit.branch"), Author: c.String("commit.author"), + Email: c.String("commit.author.email"), Message: c.String("commit.message"), Link: c.String("build.link"), Started: c.Float64("job.started"), diff --git a/plugin.go b/plugin.go index 0225bfe..ae9739b 100644 --- a/plugin.go +++ b/plugin.go @@ -27,6 +27,7 @@ type ( Message string Branch string Author string + Email string Status string Link string Started float64 @@ -134,20 +135,21 @@ func convertLocation(value string) (Location, bool) { }, false } -func parseID(keys []string) []int64 { - var newKeys []int64 +func parseTo(value, authorEmail string) (int64, bool) { + ids := trimElement(strings.Split(value, ",")) - for _, value := range keys { - id, err := strconv.ParseInt(value, 10, 64) - if err != nil { - log.Println(err.Error()) - - continue + if len(ids) > 1 { + if email := ids[1]; email != authorEmail { + return int64(0), false } - newKeys = append(newKeys, id) } - return newKeys + id, err := strconv.ParseInt(ids[0], 10, 64) + if err != nil { + return int64(0), false + } + + return id, true } // Exec executes the plugin. @@ -176,8 +178,6 @@ func (p Plugin) Exec() error { bot.Debug = p.Config.Debug - // parse ids - ids := parseID(p.Config.To) photos := fileExist(trimElement(p.Config.Photo)) documents := fileExist(trimElement(p.Config.Document)) stickers := fileExist(trimElement(p.Config.Sticker)) @@ -188,7 +188,12 @@ func (p Plugin) Exec() error { venues := trimElement(p.Config.Venue) // send message. - for _, user := range ids { + for _, to := range p.Config.To { + user, enable := parseTo(to, p.Build.Email) + if !enable { + continue + } + for _, value := range trimElement(message) { txt, err := template.RenderTrim(value, p) if err != nil { diff --git a/plugin_test.go b/plugin_test.go index 05409e0..cd12077 100644 --- a/plugin_test.go +++ b/plugin_test.go @@ -131,19 +131,31 @@ func TestTrimElement(t *testing.T) { assert.Equal(t, result, trimElement(input)) } -func TestParseID(t *testing.T) { - var input []string - var result []int64 +func TestParseTo(t *testing.T) { + id, enable := parseTo("1234567890", "test@gmail.com") - input = []string{"1", "測試", "3"} - result = []int64{int64(1), int64(3)} + assert.Equal(t, true, enable) + assert.Equal(t, int64(1234567890), id) - assert.Equal(t, result, parseID(input)) + id, enable = parseTo("1234567890,test2@gmail.com", "test@gmail.com") - input = []string{"1", "2"} - result = []int64{int64(1), int64(2)} + assert.Equal(t, false, enable) + assert.Equal(t, int64(0), id) - assert.Equal(t, result, parseID(input)) + id, enable = parseTo("1234567890,test@gmail.com", "test@gmail.com") + + assert.Equal(t, true, enable) + assert.Equal(t, int64(1234567890), id) + + id, enable = parseTo("測試,test@gmail.com", "test@gmail.com") + + assert.Equal(t, false, enable) + assert.Equal(t, int64(0), id) + + id, enable = parseTo("測試", "test@gmail.com") + + assert.Equal(t, false, enable) + assert.Equal(t, int64(0), id) } func TestCheckFileExist(t *testing.T) {