escape _ symbol for markdown format (#40)

* escape _ symbol for markdown format

* fmt

* tests

* tests

* tests
This commit is contained in:
koluchiy 2017-07-04 14:03:14 +03:00 committed by Bo-Yi Wu
parent 1c14ff5307
commit 3a61750059
2 changed files with 85 additions and 1 deletions

View File

@ -84,6 +84,27 @@ func trimElement(keys []string) []string {
return newKeys return newKeys
} }
func escapeMarkdown(keys []string) []string {
var newKeys []string
for _, value := range keys {
value = escapeMarkdownOne(value)
if len(value) == 0 {
continue
}
newKeys = append(newKeys, value)
}
return newKeys
}
func escapeMarkdownOne(str string) string {
str = strings.Replace(str, `\_`, `_`, -1)
str = strings.Replace(str, `_`, `\_`, -1)
return str
}
func fileExist(keys []string) []string { func fileExist(keys []string) []string {
var newKeys []string var newKeys []string
@ -213,9 +234,25 @@ func (p Plugin) Exec() error {
locations := trimElement(p.Config.Location) locations := trimElement(p.Config.Location)
venues := trimElement(p.Config.Venue) venues := trimElement(p.Config.Venue)
message = trimElement(message)
if p.Config.Format == "markdown" {
message = escapeMarkdown(message)
p.Build.Message = escapeMarkdownOne(p.Build.Author)
p.Build.Branch = escapeMarkdownOne(p.Build.Branch)
p.Build.Author = escapeMarkdownOne(p.Build.Author)
p.Build.Email = escapeMarkdownOne(p.Build.Email)
p.Build.Link = escapeMarkdownOne(p.Build.Link)
p.Build.PR = escapeMarkdownOne(p.Build.PR)
p.Repo.Owner = escapeMarkdownOne(p.Repo.Owner)
p.Repo.Name = escapeMarkdownOne(p.Repo.Name)
}
// send message. // send message.
for _, user := range ids { for _, user := range ids {
for _, value := range trimElement(message) { for _, value := range message {
txt, err := template.RenderTrim(value, p) txt, err := template.RenderTrim(value, p)
if err != nil { if err != nil {
return err return err

View File

@ -86,6 +86,11 @@ func TestSendMessage(t *testing.T) {
err := plugin.Exec() err := plugin.Exec()
assert.Nil(t, err) assert.Nil(t, err)
plugin.Config.Format = "markdown"
plugin.Config.Message = []string{"Test escape under_score"}
err = plugin.Exec()
assert.Nil(t, err)
// disable message // disable message
plugin.Config.Message = []string{} plugin.Config.Message = []string{}
err = plugin.Exec() err = plugin.Exec()
@ -133,6 +138,48 @@ func TestTrimElement(t *testing.T) {
assert.Equal(t, result, trimElement(input)) assert.Equal(t, result, trimElement(input))
} }
func TestEscapeMarkdown(t *testing.T) {
provider := [][][]string{
{
{"user", "repo"},
{"user", "repo"},
},
{
{"user_name", "repo_name"},
{`user\_name`, `repo\_name`},
},
{
{"user_name_long", "user_name_long"},
{`user\_name\_long`, `user\_name\_long`},
},
{
{`user\_name\_long`, `repo\_name\_long`},
{`user\_name\_long`, `repo\_name\_long`},
},
{
{`user\_name\_long`, `repo\_name\_long`, ""},
{`user\_name\_long`, `repo\_name\_long`},
},
}
for _, testCase := range provider {
assert.Equal(t, testCase[1], escapeMarkdown(testCase[0]))
}
}
func TestEscapeMarkdownOne(t *testing.T) {
provider := [][]string{
{"user", "user"},
{"user_name", `user\_name`},
{"user_name_long", `user\_name\_long`},
{`user\_name\_escaped`, `user\_name\_escaped`},
}
for _, testCase := range provider {
assert.Equal(t, testCase[1], escapeMarkdownOne(testCase[0]))
}
}
func TestParseTo(t *testing.T) { func TestParseTo(t *testing.T) {
input := []string{"0", "1:1@gmail.com", "2:2@gmail.com", "3:3@gmail.com", "4", "5"} input := []string{"0", "1:1@gmail.com", "2:2@gmail.com", "3:3@gmail.com", "4", "5"}